Fix Util#expire so that it will work for any number of dead keys #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mhenrixon
added a commit
that referenced
this pull request
Aug 19, 2017
* Fix running tests * Avoid warnings when testing console.start * Only hide errors for valid constant names * Improve test readability * Lock on the instance again * Clean up more tests * Allow raising name errors caught by configuration * Add change log entry * Parallelize rubocop * Styles * Close ##236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there was a missing loop, because the break statement was already there. Tests passing and tested it on our setup which had around 40,000 dead keys.